Extend filter behavior #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After thinking about this a little bit more, maybe this change would not be enough. Maybe introducing the "if" rule for the filter array be a better fit here. Currently (even with this change) there aren't any ways to filter by "many" multiple conditions. This change only supports one multiple conditions. // if - many multiple conditions (current behavior)
{
if: { and: [conditionOne, conditionTwo]}
then: { stuff }
},
{
if: { and: [anotherConditionOne, anotherConditionTwo]}
then: { stuff }
}
// based on this PR
// filter - works
{
filter: 'list'
run: { and: [conditionOne, conditionTwo]}
set: 'results'
}
// filter - does not work
{
{
filter: 'list'
run: { and: [conditionOne, conditionTwo]}
set: 'results'
},
{
filter: 'list'
run: { and: [anotherConditionOne, anotherConditionTwo]}
set: 'results'
}
}This is essentially combining both the return conditionOne && conditionTwo || anotherConditionOne && anotherConditionTwopossible proposed solution{
filter: 'list'
run: {
{
if: { and: [conditionOne, conditionTwo]}
then: { stuff } // optional?
},
{
if: { and: [anotherConditionOne, anotherConditionTwo]}
then: { stuff } // optional?
}
}
set: 'results'
}{
{
filter: 'list'
run: { and: [conditionOne, conditionTwo]}
set: 'results'
},
{
filter: 'list'
run: { and: [anotherConditionOne, anotherConditionTwo]}
set: 'results'
}
}I need to grok on this a little bit more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35
Support for multi conditions in
filterarray operation.Includes updated documentation.