You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the user as a global core.hooksPath hook set (example: yours truly), aurpublish setup doesn't work.
One needs to explicitly set git config core.hooksPath .git/hooks in the aurpublish-backed repository.
Thinking a bit deeper about this, I don't think it's an aurpublish bug per se, it feels more like a bug in git.
I'd argue git should honor the implicit local hooks path over the global one if at least one hook exists therein.
Anyway, just wanted to file this as a heads up. aurpublish could optionally take care of this defensively by calling git config core.hooksPath .git/hooks as part of aurpublish setup. If you would like a PR I am happy do send you one. If you think this is unnecessary, feel free to close the issue, of course.
The text was updated successfully, but these errors were encountered:
thiagowfx
changed the title
aurpublish setup doesn't effectively work when global core.hooksPath is setaurpublish setup doesn't effectively work when global core.hooksPath is set
Jan 2, 2022
thiagowfx
added a commit
to thiagowfx/PKGBUILDs
that referenced
this issue
Jan 2, 2022
Thinking a bit deeper about this, I don't think it's an aurpublish bug per se, it feels more like a bug in git.
I'd argue git should honor the implicit local hooks path over the global one if at least one hook exists therein.
A counter-argument is that if you temporarily override the hooks location you should not need to delete your hooks directory just to make git respect your explicitly set option.
If you would like a PR I am happy do send you one. If you think this is unnecessary, feel free to close the issue, of course.
If the user as a global
core.hooksPath
hook set (example: yours truly),aurpublish setup
doesn't work.One needs to explicitly set
git config core.hooksPath .git/hooks
in the aurpublish-backed repository.Thinking a bit deeper about this, I don't think it's an aurpublish bug per se, it feels more like a bug in
git
.I'd argue git should honor the implicit local hooks path over the global one if at least one hook exists therein.
Anyway, just wanted to file this as a heads up.
aurpublish
could optionally take care of this defensively by callinggit config core.hooksPath .git/hooks
as part ofaurpublish setup
. If you would like a PR I am happy do send you one. If you think this is unnecessary, feel free to close the issue, of course.The text was updated successfully, but these errors were encountered: