Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] suppress prepare-commit-msg temporarily / permanent #11

Open
LW-archlinux opened this issue Apr 19, 2020 · 4 comments
Open

Comments

@LW-archlinux
Copy link

I do like the prepare-commit-msg hook, but feel it's overkill for packages that change package versions frequently like VCS packages.

An option to suppress the hook temporarily or permanently for specific packages would help .

Possible invocations :
aurpublish -rm_auto_commit_hook PACKAGE
aurpublish -suppress_auto_commit_hook_once PACKAGE

@eli-schwartz
Copy link
Owner

I don't often update VCS packages -- only when there are upstream changes to the build system.

Incidentally, what do you see as overkill about it? Note that it's used at git commit time, so I'm not sure what it would look like to disable with options to aurpublish anyway.

@LW-archlinux
Copy link
Author

I often add patches to solve something and remove them after they've been accepted to master. Also llvm trunk changes build options rather often .

The overkill happens mainly because I try to keep commits small to make it easier to test changes.
An example are the last 5 changes at https://aur.archlinux.org/cgit/aur.git/log/?h=llvm-git . They happened within a few hours and I only pushed them after the last commit.

A hook that is triggered by git push instead of git commit could solve that, is such a hook possible ?

@eli-schwartz
Copy link
Owner

A hook that is triggered by git push instead of git commit could solve that, is such a hook possible ?

No, the hook prepares a commit message and must therefore be run at the time you create the commit... on push can't affect that.

One possibility might be to have a config file in the repository which the hook would read, and use to disable its commit-msg suggestion for certain packages (or alternatively, to provide a different one).

@eli-schwartz
Copy link
Owner

Is this something you're interested in investigating and possibly providing a patch to implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants