Skip to content

Color tag menuitem does not show colors in High Contrast theme - but view does #1230

@jeremypw

Description

@jeremypw
Collaborator

I have searched open and closed issues for duplicates.

Describe the bug

The context menuitem for changing color tags does not show the colors if you switch to High Contrast theme. But in the view tag colors are still shown.

Screenshot from 2020-02-08 20 27 08

To Reproduce

Steps to reproduce the behavior:

  1. Change the Gtk theme to "High Contrast"
  2. In FIles, secondary click on a file item to show the context menu
  3. The Color tag menu item is monochrome although it does work and color tags are correctly displayed in the view.

Expected behavior

Either both color tags and the corresponding menuitem should not be shown if the theme is not "elementary" or both color tags and the corresponding menuitem should display properly.

Platform Information

Hera 5.1 daily

I'm using the latest version from git that I've manually compiled

Additional context

Unsure whether non-elementary themes are generally supported but this is an accessibility issue.

Activity

Teraskull

Teraskull commented on Feb 27, 2020

@Teraskull
Contributor

Unsure whether non-elementary themes are generally supported but this is an accessibility issue.

I tried a lot of themes, none of them supports the color label panel.

jeremypw

jeremypw commented on Feb 27, 2020

@jeremypw
CollaboratorAuthor

I think this is caused by the menu using elementary theme color definitions to get the colors following this commit 9a6dfac. These colors are not generally defined in other themes. The view, however still uses hard coded colors (matching the elementary theme). I think we need to hard code the colors in the css used by the menuitem to resolve this, if we want to support color tags in other themes.

jeremypw

jeremypw commented on Feb 27, 2020

@jeremypw
CollaboratorAuthor

Otherwise we disable the color-tag plugin if the theme is not elementary.

jeremypw

jeremypw commented on Feb 28, 2020

@jeremypw
CollaboratorAuthor

Discussion on Slack has so far shown little appetite to support high contrast (monochrome) themes as the elementary theme is intended to be "high enough contrast" that is compliant with WCAG AAA or AA. Any instance where that is not the case should be raised as an issue against the theme. Looks like we will not be fixing this issue therefore.

jeremypw

jeremypw commented on Feb 28, 2020

@jeremypw
CollaboratorAuthor

Except that we may use css for both view and menuitem at some point which would at least make them consistent.

danirabbit

danirabbit commented on Apr 21, 2025

@danirabbit
Member

Just noting that this will be automatically fixed after a GTK4 port since these days we supply these color definitions in Granite

moved this to Blocked in GTK4 Portingon Apr 23, 2025
moved this to Todo in A11yon May 12, 2025
added theissue type on Jun 8, 2025
added this to the 8.0.0 milestone on Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    AccessibilityAffecting usability for differently abled users

    Type

    Projects

    Status

    Blocked

    Status

    Todo

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @danirabbit@jeremypw@Teraskull

        Issue actions

          Color tag menuitem does not show colors in High Contrast theme - but view does · Issue #1230 · elementary/files