Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide AppStream validation #37

Open
cassidyjames opened this issue Apr 16, 2020 · 4 comments
Open

Provide AppStream validation #37

cassidyjames opened this issue Apr 16, 2020 · 4 comments
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Apr 16, 2020

Much like the lint action, it would be handy to provide an AppStream data validation action so we can ensure things are valid before they're merged. Would avoid issues with malformed AppData, missing tags, etc.

@cassidyjames cassidyjames added Priority: Wishlist Not a priority, but something that might be nice Needs Design Waiting for input from the UX team labels Apr 16, 2020
@kgrubb
Copy link
Contributor

kgrubb commented Apr 16, 2020

Should this be its own action even though its super tiny/short? I'm thinking yes, but I'm not certain 😄

@decathorpe
Copy link

It would be great if appdata could be validated both with appstream and appstream-glib - even in the "relaxed" mode, the latter is stricter for some checks (and for some other checks, it's the other way round). Validating with both major implementations should cover most issues.

(appstream is used by AppCenter and KDE, appstream-glib is used by GNOME / PackageKit - so basically everybody except Appcenter and KDE)

@kgrubb
Copy link
Contributor

kgrubb commented Apr 16, 2020

I added appstream-util validate-relax --nonet, which should cover appstream-glib I think? Where's the best place to take a look at the other validator?

@decathorpe
Copy link

@kgrubb I've left some feedback on your PR, including how to invoke the non-glib appstream validator CLI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants