Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lineHeight warnings in React Native #25

Open
macintoshhelper opened this issue May 12, 2020 · 0 comments
Open

lineHeight warnings in React Native #25

macintoshhelper opened this issue May 12, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority: low

Comments

@macintoshhelper
Copy link
Member

There are lineHeight warnings in the console in development mode in React Native. I applied a fix that should be transforming line heights to px, but for some peculiar reason, the warnings are still being given.

Relevant code: https://github.com/elemental-design/elemental-react/blob/master/src/atoms/Text/Text.tsx#L20-L24
@macintoshhelper macintoshhelper added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers priority: low labels May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macintoshhelper