Add memberships admin API
#19260
Open
Add memberships admin API
#19260
+162
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
admin-left-rooms
branch
2 times, most recently
from
b5263c3 to
f845b3f
Compare
MatMaul
force-pushed
the
admin-left-rooms
branch
from
f845b3f to
a9f0db8
Compare
MatMaul
force-pushed
the
admin-left-rooms
branch
from
a9f0db8 to
ded0f1f
Compare
MatMaul
commented
Dec 2, 2025
|
|
||
| return frozenset(room_ids) | ||
|
|
||
| async def get_memberships_for_user(self, user_id: str) -> dict[str, str]: |
Contributor
Author
There was a problem hiding this comment.
Do we want a cache here ? if yes we also need to add invalidation.
I didn't do it because it should be used not that often since it is only used by the admin API (for now).
| return dict(rows) | ||
|
|
||
| @cached(max_entries=500000, iterable=True) | ||
| async def get_rooms_for_user(self, user_id: str) -> frozenset[str]: |
Contributor
Author
There was a problem hiding this comment.
Should we change this to use get_memberships_for_user ? it will pull quite a lot more data and this is used in a lot of places so I am tempted to not touch it to not affect performances.
Contributor
Author
There was a problem hiding this comment.
Another option would be to make get_memberships_for_user take a list of membership we are interested in, with empty meaning everything.
In this case the perf would be basically the same (with a cache on get_memberships_for_user and not on get_rooms_for_user anymore).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
membershipsendpoint to the admin API. This is useful for forensics and T&S purpose.Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.