Optimise notifier #17765
Open
Optimise notifier #17765
+43
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can update the counter once outside of the loop.
Turns out doing `.copy_and_advance` can be expensive
erikjohnston
commented
Sep 27, 2024
|
|
||
| # The last token for which we should wake up any streams that have a | ||
| # token that comes before it. This gets updated every time we get poked. | ||
| # We start it at the current token since if we get any streams | ||
| # that have a token from before we have no idea whether they should be | ||
| # woken up or not, so lets just wake them up. | ||
| self.last_notified_token = current_token | ||
| self.current_token = current_token |
There was a problem hiding this comment.
These two variables were always the same, so may as well remove one of them
erikjohnston
commented
Sep 27, 2024
| sync_channel.await_result() | ||
| self.assertEqual(200, sync_channel.code) | ||
| next_batch = sync_channel.json_body["next_batch"] | ||
|
|
There was a problem hiding this comment.
This is because we now replace the current token rather than copy_and_advance. The test is still asserting the same observable behaviour really.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notifier is quite inefficient when it has to wake up many user streams all at once
From a silly benchmark this takes the time to notify 1M user streams from ~30s to ~5s