Skip to content

Commit f6560c7

Browse files
author
John Kleinschmidt
authored
Merge pull request #34 from electron/update-for-4-0-x
feat: update for 4-0-x release line
2 parents 5891e1e + 6870a90 commit f6560c7

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "electron-chromedriver",
3-
"version": "3.0.0",
3+
"version": "4.0.0-beta.1",
44
"description": "Electron ChromeDriver",
55
"repository": "https://github.com/electron/chromedriver",
66
"bin": {

test/chromedriver-test.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
const assert = require('assert')
22
const ChildProcess = require('child_process')
33
const path = require('path')
4+
const { version } = require('../package')
45

56
const describe = global.describe
67
const it = global.it
@@ -20,7 +21,12 @@ describe('chromedriver binary', function () {
2021
chromeDriver.stderr.on('data', data => output += data)
2122

2223
chromeDriver.on('close', () => {
23-
assert.equal(output.indexOf('ChromeDriver 2.36'), 0, `Unexpected version: ${output}`)
24+
if (version.startsWith('3')) {
25+
assert.equal(output.indexOf('ChromeDriver 2.36'), 0, `Unexpected version: ${output}`)
26+
} else if (version.startsWith('4')) {
27+
// see src/chrome/test/chromedriver/embed_version_in_cpp.py
28+
assert.equal(output.indexOf('ChromeDriver 69.0.3497.106'), 0, `Unexpected version: ${output}`)
29+
}
2430
})
2531

2632
chromeDriver.on('error', done)

0 commit comments

Comments
 (0)