Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this stable? #7

Open
frostyplanet opened this issue Aug 27, 2022 · 3 comments
Open

Is this stable? #7

frostyplanet opened this issue Aug 27, 2022 · 3 comments

Comments

@frostyplanet
Copy link

The c version release final version in 2022.4, any code sync from the original c version?

@eldruin
Copy link
Owner

eldruin commented Aug 28, 2022

What do you mean by "stable"?
The last published version of this crate implements the original version. I have also implemented version "final 3" (available here) but I have seen some performance regressions so I have not published it.

@frostyplanet
Copy link
Author

frostyplanet commented Aug 28, 2022

Got it, because I saw 0.5.0 is not the newest commit. Is 0.5.0 implement according to final3 ?
Any plan to publisher the latest code?

We'd like to use this crate in production, but we have to make sure the hash result does not change in the future.

@PaulGrandperrin
Copy link

oh, I'm in the exact same situation as @frostyplanet :)

There are quite a lot of versions on the table there: https://github.com/wangyi-fudan/wyhash and when we look at the README here, it's not clear which version we are talking about.

I'm also interested in final3, and I'm fine if performance is not perfect yet, however, I really care about the stability of the output hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants