[RAM] Remove third party RRule library, replace with own timezone-compliant lib

[Zacqary]

Summary

Closes #152630

Adds a fix for the weird UTC-but-not-really expected inputs in rrule.js

This PR removes the third-party rrule package and replaces it with @kbn/rrule.

The third party RRule library's functions produced different results depending on what system timezone you ran it in. It would output local timestamps in UTC, making it impossible to do reliable math on them. It's now replaced with our own library that passes all of our own tests for the limited cross-section of the RRule spec that we need to support. It's possible that it wouldn't stand up to the rigor of more complex RRule queries, but it supports the ones that our Recurrence Scheduler UI supports just fine.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[JiaweiWu]

LGTM! I like the approach taken.

I wonder if there's a good way to notify people to not use the rrule library by itself.

[Zacqary]

Ok so as you can see by the failing Jest test, the solution is not actually this simple as it turns out

Putting in the right timestamp doesn't get around the fact that the before function will return different results if you run it in a different system timezone

We can't just say "don't use timezones" because days of the week are timezone dependent

I might have to just rewrite this rrule library

[Zacqary]

Noticed a bug in my RRule implementation when mixing byweekday positions such as "first tuesday of the month and last friday of the month", i.e. ['+1TU', '-2FR']

This configuration isn't currently supported in the Recurrence Scheduler UI so this is shippable as-is, but I do want to fix that.

EDIT: Fixed in 8cba1ed

[sabarasaba]

Heya! @elastic/platform-deployment-management got pinged for a small change removing an empty line at src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts, not sure thats needed? 🤔

[Zacqary]

@elasticmachine merge upstream

[Zacqary]

@elasticmachine merge upstream

[XavierM]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 04e93b0

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/rrule	-	16	+16
alerting	611	595	-16
total			-0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
alerting	184.6KB	65.1KB	-119.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/rrule	-	1	+1

Unknown metric groups

API count

id	before	after	diff
@kbn/rrule	-	16	+16
alerting	635	619	-16
total			-0

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	413	417	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	492	496	+4
total			+6

History

• 💔 Build #139660 failed c41c708
• 💔 Build #139548 failed beb74df
• 💚 Build #139273 succeeded 5d09e64
• 💛 Build #139243 was flaky 23c7885
• 💚 Build #129345 succeeded de5ab98

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.9	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 152873

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152873 locally

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152873 locally

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152873 locally

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152873 locally

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152873 locally

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 152873 locally