-
Notifications
You must be signed in to change notification settings - Fork 100
Make File Transfer Storage Size Configurable #5478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
This pull request does not have a backport label. Could you fix it @pzl? 🙏
|
|
| # If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added. | ||
| # NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number. | ||
| # Please provide it if you are adding a fragment for a different PR. | ||
| #pr: https://github.com/owner/repo/1234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #pr: https://github.com/owner/repo/1234 | |
| pr: https://github.com/elastic/fleet-server/pull/5478 |
|
@pzl do you plan to continue work on this PR? If not, I'll plan to close, and you can reopen/recreate when ready to work on it again. |
Thanks @ebeahan , we're actually picking this back up now! Seems like where this left off, was discussion around what type the storage size variable should be, and meanings on edge case numbers (0, negative values), for some concept of "unlimited". @ycombinator @nkvoll @pchila Can we reach a consensus on what we want that to be? |
Apologies for missing this ping (thanks @ebeahan). I think we're pretty close / aligned; here's my take: #5478 (comment) |
|
I'm on board with what @ycombinator wrote above, that makes sense to me 👍 |
@ycombinator proposal works for me as well 👍 |
|
Thanks all, made the change so that |




What is the problem this PR solves?
Adds a configuration parameter to fleet server for the maximum size of transferred files via actions
How does this PR solve the problem?
Hard coded limit (100MiB previously) is now a config.
Default is also changed to be unlimited. The file transfer feature launched with very conservative limits on request rates and file sizes. File size itself is primarily an impact on Elasticsearch at rest, at does not effect fleet server, aside from the time to transfer the bytes. Requests are still chunked, chunk size is not changing.
Design Checklist
Checklist
./changelog/fragmentsusing the changelog tool