Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better unit tests for ESQL In Operator #119480

Open
not-napoleon opened this issue Jan 2, 2025 · 1 comment
Open

Better unit tests for ESQL In Operator #119480

not-napoleon opened this issue Jan 2, 2025 · 1 comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests

Comments

@not-napoleon
Copy link
Member

Update the IN tests to use the normal test generation tools. We may not be able to use anyNullIsNull, since IN has some unique null handling behavior, but we should be able to use errorsForCasesWithoutExamples, and the data generation functions. This should also produce a types table for the docs, which is currently missing.

Additionally, it would be nice to document the null behavior and different code generation process in the javadoc for the operator.
@not-napoleon not-napoleon added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests labels Jan 2, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@nik9000 nik9000 mentioned this issue Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@not-napoleon @elasticsearchmachine