spotless

Author: prdoyle

server/src/main/java/org/elasticsearch/common/settings/Setting.java

@@ -1737,7 +1737,8 @@ public static Setting<String> simpleString(String key, Setting<String> fallback,
      * @param lookup is used to access the constructor and component getters, allowing {@code RecordClass} to be non-public.
      * @param relevantSettings supply configuration for the components, including (recursively) any components in any
      *                         nested records.
-     * @param properties apply to this {@link Setting} as a whole, and by default to any component settings not specified by {@code relevantSettings}.
+     * @param properties apply to this {@link Setting} as a whole,
+     *                  and by default to any component settings not specified by {@code relevantSettings}.
      * @return the {@link Setting}
      * @param <R> the type of {@code recordClass}
      */

server/src/test/java/org/elasticsearch/common/settings/SettingTests.java

@@ -23,7 +23,6 @@
 import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.test.MockLog;
 import org.elasticsearch.test.junit.annotations.TestLogging;
-import org.junit.Test;
 
 import java.lang.invoke.MethodHandles;
 import java.util.Arrays;
@@ -1623,7 +1622,7 @@ record TestSetting(int intSetting) {}
         assertNull("Creating an updater does not call set", watcher.get());
         updater.apply(settings456, settings123);
         assertEquals("Updater called when value changed", new TestSetting(456), watcher.get());
-        assertThrows("Throws when there's no default", IllegalStateException.class, ()->updater.apply(Settings.EMPTY, settings456));
+        assertThrows("Throws when there's no default", IllegalStateException.class, () -> updater.apply(Settings.EMPTY, settings456));
 
         watcher.set(null);
         updater.apply(settings123, settings123);
@@ -1636,10 +1635,18 @@ public void testRecordWithDefaults() {
         record TestSetting(int i1, int i2) {}
         Setting<Integer> i1Setting = Setting.intSetting("record.setting.i1", -1);
         Setting<Integer> i2Setting = Setting.intSetting("record.setting.i2", -2);
-        Setting<TestSetting> setting = Setting.recordSetting("record.setting", TestSetting.class, MethodHandles.lookup(), List.of(i1Setting, i2Setting));
+        Setting<TestSetting> setting = Setting.recordSetting(
+            "record.setting",
+            TestSetting.class,
+            MethodHandles.lookup(),
+            List.of(i1Setting, i2Setting)
+        );
         Settings settings123 = Settings.builder().put("record.setting.i1", 123).build();
 
-        assertEquals(new TestSetting(123, 456), setting.get(Settings.builder().put("record.setting.i1", 123).put("record.setting.i2", 456).build()));
+        assertEquals(
+            new TestSetting(123, 456),
+            setting.get(Settings.builder().put("record.setting.i1", 123).put("record.setting.i2", 456).build())
+        );
         assertEquals(new TestSetting(-1, 456), setting.get(Settings.builder().put("record.setting.i2", 456).build()));
         assertEquals(new TestSetting(-1, -2), setting.get(Settings.EMPTY));
 
@@ -1660,14 +1667,16 @@ record TestSetting(int i1, int i2) {}
 
     public void testAffixRecordSetting() {
         record TestSetting(int intSetting) {}
-        var componentSetting = Setting.affixKeySetting(
-            "things.",
-            "config.int_setting",
-            (n,key)-> Setting.intSetting(key, -1));
+        var componentSetting = Setting.affixKeySetting("things.", "config.int_setting", (n, key) -> Setting.intSetting(key, -1));
         var setting = Setting.affixKeySetting(
             "things.",
             "config",
-            (namespace, key) -> Setting.recordSetting(key, TestSetting.class, MethodHandles.lookup(), List.of(componentSetting.getConcreteSettingForNamespace(namespace)))
+            (namespace, key) -> Setting.recordSetting(
+                key,
+                TestSetting.class,
+                MethodHandles.lookup(),
+                List.of(componentSetting.getConcreteSettingForNamespace(namespace))
+            )
         );
         Settings settings = Settings.builder()
             .put("things.thing1.config.int_setting", 123)
@@ -1676,14 +1685,12 @@ record TestSetting(int intSetting) {}
         assertEquals(new TestSetting(123), setting.getConcreteSetting("things.thing1.config").get(settings));
         assertEquals(new TestSetting(456), setting.getConcreteSetting("things.thing2.config").get(settings));
 
-        Settings settings1 = Settings.builder()
-            .put("things.thing1.config.int_setting", 123)
-            .build();
+        Settings settings1 = Settings.builder().put("things.thing1.config.int_setting", 123).build();
         assertEquals(new TestSetting(123), setting.getConcreteSetting("things.thing1.config").get(settings));
         assertEquals("Default", new TestSetting(-1), setting.getConcreteSetting("things.thing2.config").get(settings1));
 
         Map<String, TestSetting> watcher = new ConcurrentHashMap<>();
-        var updater = setting.newAffixUpdater(watcher::put, logger, (k, s)->{});
+        var updater = setting.newAffixUpdater(watcher::put, logger, (k, s) -> {});
 
         // Test the obvious state transitions
         updater.apply(settings1, Settings.EMPTY);