Remove unused methods from SearchContext (#107111)

A couple methods can be removed here, they're only used on sub-classes.
That also cleans up some unsupport operation exception code that is never hit.

Author: original-brownbear

server/src/main/java/org/elasticsearch/search/DefaultSearchContext.java

@@ -481,7 +481,6 @@ public SearchContext aggregations(SearchContextAggregations aggregations) {
         return this;
     }
 
-    @Override
     public void addSearchExt(SearchExtBuilder searchExtBuilder) {
         // it's ok to use the writeable name here given that we enforce it to be the same as the name of the element that gets
         // parsed by the corresponding parser. There is one single name and one single way to retrieve the parsed object from the context.
@@ -508,7 +507,6 @@ public SuggestionSearchContext suggest() {
         return suggest;
     }
 
-    @Override
     public void suggest(SuggestionSearchContext suggest) {
         this.suggest = suggest;
     }
@@ -613,7 +611,6 @@ public TimeValue timeout() {
         return timeout;
     }
 
-    @Override
     public void timeout(TimeValue timeout) {
         this.timeout = timeout;
     }
@@ -688,7 +685,6 @@ public FieldDoc searchAfter() {
         return searchAfter;
     }
 
-    @Override
     public SearchContext collapse(CollapseContext collapse) {
         this.collapse = collapse;
         return this;
@@ -786,7 +782,6 @@ public List<String> groupStats() {
         return this.groupStats;
     }
 
-    @Override
     public void groupStats(List<String> groupStats) {
         this.groupStats = groupStats;
     }

server/src/main/java/org/elasticsearch/search/internal/FilteredSearchContext.java

@@ -139,11 +139,6 @@ public SuggestionSearchContext suggest() {
         return in.suggest();
     }
 
-    @Override
-    public void suggest(SuggestionSearchContext suggest) {
-        in.suggest(suggest);
-    }
-
     @Override
     public RankShardContext rankShardContext() {
         return in.rankShardContext();
@@ -204,11 +199,6 @@ public TimeValue timeout() {
         return in.timeout();
     }
 
-    @Override
-    public void timeout(TimeValue timeout) {
-        in.timeout(timeout);
-    }
-
     @Override
     public int terminateAfter() {
         return in.terminateAfter();
@@ -334,11 +324,6 @@ public List<String> groupStats() {
         return in.groupStats();
     }
 
-    @Override
-    public void groupStats(List<String> groupStats) {
-        in.groupStats(groupStats);
-    }
-
     @Override
     public boolean version() {
         return in.version();
@@ -409,11 +394,6 @@ public long getRelativeTimeInMillis() {
         return in.getRelativeTimeInMillis();
     }
 
-    @Override
-    public void addSearchExt(SearchExtBuilder searchExtBuilder) {
-        in.addSearchExt(searchExtBuilder);
-    }
-
     @Override
     public SearchExtBuilder getSearchExt(String name) {
         return in.getSearchExt(name);
@@ -444,11 +424,6 @@ public boolean isCancelled() {
         return in.isCancelled();
     }
 
-    @Override
-    public SearchContext collapse(CollapseContext collapse) {
-        return in.collapse(collapse);
-    }
-
     @Override
     public CollapseContext collapse() {
         return in.collapse();

server/src/main/java/org/elasticsearch/search/internal/SearchContext.java

@@ -122,8 +122,6 @@ public final void close() {
 
     public abstract SearchContext aggregations(SearchContextAggregations aggregations);
 
-    public abstract void addSearchExt(SearchExtBuilder searchExtBuilder);
-
     public abstract SearchExtBuilder getSearchExt(String name);
 
     public abstract SearchHighlightContext highlight();
@@ -139,8 +137,6 @@ public InnerHitsContext innerHits() {
 
     public abstract SuggestionSearchContext suggest();
 
-    public abstract void suggest(SuggestionSearchContext suggest);
-
     public abstract RankShardContext rankShardContext();
 
     public abstract void rankShardContext(RankShardContext rankShardContext);
@@ -217,8 +213,6 @@ public final void assignRescoreDocIds(RescoreDocIds rescoreDocIds) {
 
     public abstract TimeValue timeout();
 
-    public abstract void timeout(TimeValue timeout);
-
     public abstract int terminateAfter();
 
     public abstract void terminateAfter(int terminateAfter);
@@ -255,8 +249,6 @@ public final void assignRescoreDocIds(RescoreDocIds rescoreDocIds) {
 
     public abstract FieldDoc searchAfter();
 
-    public abstract SearchContext collapse(CollapseContext collapse);
-
     public abstract CollapseContext collapse();
 
     public abstract SearchContext parsedPostFilter(ParsedQuery postFilter);
@@ -310,8 +302,6 @@ public Query rewrittenQuery() {
     @Nullable
     public abstract List<String> groupStats();
 
-    public abstract void groupStats(List<String> groupStats);
-
     public abstract boolean version();
 
     public abstract void version(boolean version);

server/src/main/java/org/elasticsearch/search/internal/SubSearchContext.java

@@ -9,7 +9,6 @@
 
 import org.apache.lucene.search.Query;
 import org.apache.lucene.search.TotalHits;
-import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.index.query.ParsedQuery;
 import org.elasticsearch.search.aggregations.SearchContextAggregations;
 import org.elasticsearch.search.collapse.CollapseContext;
@@ -22,9 +21,6 @@
 import org.elasticsearch.search.fetch.subphase.highlight.SearchHighlightContext;
 import org.elasticsearch.search.query.QuerySearchResult;
 import org.elasticsearch.search.sort.SortAndFormats;
-import org.elasticsearch.search.suggest.SuggestionSearchContext;
-
-import java.util.List;
 
 public class SubSearchContext extends FilteredSearchContext {
 
@@ -104,11 +100,6 @@ public void highlight(SearchHighlightContext highlight) {
         this.highlight = highlight;
     }
 
-    @Override
-    public void suggest(SuggestionSearchContext suggest) {
-        throw new UnsupportedOperationException("Not supported");
-    }
-
     @Override
     public boolean hasScriptFields() {
         return scriptFields != null && scriptFields.fields().isEmpty() == false;
@@ -160,11 +151,6 @@ public SubSearchContext fetchFieldsContext(FetchFieldsContext fetchFieldsContext
         return this;
     }
 
-    @Override
-    public void timeout(TimeValue timeout) {
-        throw new UnsupportedOperationException("Not supported");
-    }
-
     @Override
     public void terminateAfter(int terminateAfter) {
         throw new UnsupportedOperationException("Not supported");
@@ -269,11 +255,6 @@ public void explain(boolean explain) {
         this.explain = explain;
     }
 
-    @Override
-    public void groupStats(List<String> groupStats) {
-        throw new UnsupportedOperationException("Not supported");
-    }
-
     @Override
     public boolean version() {
         return version;

server/src/main/java/org/elasticsearch/search/rank/RankSearchContext.java

@@ -257,11 +257,6 @@ public SearchContext aggregations(SearchContextAggregations aggregations) {
         throw new UnsupportedOperationException();
     }
 
-    @Override
-    public void addSearchExt(SearchExtBuilder searchExtBuilder) {
-        throw new UnsupportedOperationException();
-    }
-
     @Override
     public SearchExtBuilder getSearchExt(String name) {
         throw new UnsupportedOperationException();
@@ -287,11 +282,6 @@ public SuggestionSearchContext suggest() {
         throw new UnsupportedOperationException();
     }
 
-    @Override
-    public void suggest(SuggestionSearchContext suggest) {
-        throw new UnsupportedOperationException();
-    }
-
     @Override
     public RankShardContext rankShardContext() {
         throw new UnsupportedOperationException();
@@ -357,11 +347,6 @@ public BitsetFilterCache bitsetFilterCache() {
         throw new UnsupportedOperationException();
     }
 
-    @Override
-    public void timeout(TimeValue timeout) {
-        throw new UnsupportedOperationException();
-    }
-
     @Override
     public void terminateAfter(int terminateAfter) {
         throw new UnsupportedOperationException();
@@ -397,11 +382,6 @@ public SearchContext searchAfter(FieldDoc searchAfter) {
         throw new UnsupportedOperationException();
     }
 
-    @Override
-    public SearchContext collapse(CollapseContext collapse) {
-        throw new UnsupportedOperationException();
-    }
-
     @Override
     public SearchContext parsedPostFilter(ParsedQuery postFilter) {
         throw new UnsupportedOperationException();
@@ -457,11 +437,6 @@ public List<String> groupStats() {
         throw new UnsupportedOperationException();
     }
 
-    @Override
-    public void groupStats(List<String> groupStats) {
-        throw new UnsupportedOperationException();
-    }
-
     @Override
     public boolean version() {
         throw new UnsupportedOperationException();

test/framework/src/main/java/org/elasticsearch/test/TestSearchContext.java

@@ -171,11 +171,6 @@ public SearchContext aggregations(SearchContextAggregations searchContextAggrega
         return this;
     }
 
-    @Override
-    public void addSearchExt(SearchExtBuilder searchExtBuilder) {
-        searchExtBuilders.put(searchExtBuilder.getWriteableName(), searchExtBuilder);
-    }
-
     @Override
     public SearchExtBuilder getSearchExt(String name) {
         return searchExtBuilders.get(name);
@@ -194,9 +189,6 @@ public SuggestionSearchContext suggest() {
         return null;
     }
 
-    @Override
-    public void suggest(SuggestionSearchContext suggest) {}
-
     @Override
     public List<RescoreContext> rescore() {
         return Collections.emptyList();
@@ -267,9 +259,6 @@ public TimeValue timeout() {
         return TimeValue.ZERO;
     }
 
-    @Override
-    public void timeout(TimeValue timeout) {}
-
     @Override
     public int terminateAfter() {
         return terminateAfter;
@@ -340,11 +329,6 @@ public FieldDoc searchAfter() {
         return searchAfter;
     }
 
-    @Override
-    public SearchContext collapse(CollapseContext collapse) {
-        return null;
-    }
-
     @Override
     public CollapseContext collapse() {
         return null;
@@ -431,9 +415,6 @@ public List<String> groupStats() {
         return null;
     }
 
-    @Override
-    public void groupStats(List<String> groupStats) {}
-
     @Override
     public boolean version() {
         return false;