ignore obsolete warning in tests (#8290)

svalbuena · flobernd · commit 276178712d3b · 2024-08-09T14:58:57.000+02:00
diff --git a/.editorconfig b/.editorconfig
@@ -203,6 +203,10 @@ resharper_redundant_argument_default_value_highlighting=do_not_show
 spelling_languages=en-us,en-gb
 spelling_exclusion_path=exclusion.dic
 
+[{tests/**.cs}]
+# CS0618: Type or member is obsolete, tests are testing methods we have marked as obsolete that are still bundled in the client
+dotnet_diagnostic.CS0618.severity = none
+
 [Jenkinsfile]
 indent_style = space
 indent_size = 2
diff --git a/tests/Tests/Aggregations/AggregationMetaUsageTests.cs b/tests/Tests/Aggregations/AggregationMetaUsageTests.cs
@@ -12,9 +12,7 @@
 
 namespace Tests.Aggregations;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class AggregationMetaUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public AggregationMetaUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Bucket/TermsAggregationUsageTests.cs b/tests/Tests/Aggregations/Bucket/TermsAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Bucket;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class TermsAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public TermsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/AverageAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/AverageAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class AverageAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public AverageAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/BoxplotAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/BoxplotAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class BoxplotAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public BoxplotAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/CardinalityAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/CardinalityAggregationUsageTests.cs
@@ -12,9 +12,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class CardinalityAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public CardinalityAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/ExtendedStatsAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/ExtendedStatsAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class ExtendedStatsAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public ExtendedStatsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/MaxAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/MaxAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class MaxAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public MaxAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/MedianAbsoluteDeviationAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/MedianAbsoluteDeviationAggregationUsageTests.cs
@@ -11,9 +11,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class MedianAbsoluteDeviationAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public MedianAbsoluteDeviationAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/MinAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/MinAggregationUsageTests.cs
@@ -12,9 +12,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class MinAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public MinAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/StatsAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/StatsAggregationUsageTests.cs
@@ -12,9 +12,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class StatsAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public StatsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/StringStatsAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/StringStatsAggregationUsageTests.cs
@@ -12,9 +12,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class StringStatsAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public StringStatsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/StringStatsWithDistributionAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/StringStatsWithDistributionAggregationUsageTests.cs
@@ -12,9 +12,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class StringStatsWithDistributionAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public StringStatsWithDistributionAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/SumAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/SumAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class SumAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public SumAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/ValueCountAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/ValueCountAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class ValueCountAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public ValueCountAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/Metric/WeightedAverageAggregationUsageTests.cs b/tests/Tests/Aggregations/Metric/WeightedAverageAggregationUsageTests.cs
@@ -13,9 +13,7 @@
 
 namespace Tests.Aggregations.Metric;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public class WeightedAverageAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	public WeightedAverageAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }
 
diff --git a/tests/Tests/Aggregations/ProjectsOnlyAggregationUsageTestBase.cs b/tests/Tests/Aggregations/ProjectsOnlyAggregationUsageTestBase.cs
@@ -8,9 +8,7 @@
 
 namespace Tests.Aggregations;
 
-#pragma warning disable CS0618 // Type or member is obsolete
 public abstract class ProjectsOnlyAggregationUsageTestBase : AggregationUsageTestBase<ReadOnlyCluster>
-#pragma warning restore CS0618 // Type or member is obsolete
 {
 	protected ProjectsOnlyAggregationUsageTestBase(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
 

Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,7 @@`
`12`	`12`
`13`	`13`	`namespace Tests.Aggregations;`
`14`	`14`
`15`		`-#pragma warning disable CS0618 // Type or member is obsolete`
`16`	`15`	`public class AggregationMetaUsageTests : AggregationUsageTestBase<ReadOnlyCluster>`
`17`		`-#pragma warning restore CS0618 // Type or member is obsolete`
`18`	`16`	`{`
`19`	`17`	`public AggregationMetaUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }`
`20`	`18`
Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,7 @@`
`13`	`13`
`14`	`14`	`namespace Tests.Aggregations.Bucket;`
`15`	`15`
`16`		`-#pragma warning disable CS0618 // Type or member is obsolete`
`17`	`16`	`public class TermsAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>`
`18`		`-#pragma warning restore CS0618 // Type or member is obsolete`
`19`	`17`	`{`
`20`	`18`	`public TermsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }`
`21`	`19`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace Tests.Aggregations.Metric;`
`13`	`13`
`14`		`-#pragma warning disable CS0618 // Type or member is obsolete`
`15`	`14`	`public class MedianAbsoluteDeviationAggregationUsageTests : AggregationUsageTestBase<ReadOnlyCluster>`
`16`		`-#pragma warning restore CS0618 // Type or member is obsolete`
`17`	`15`	`{`
`18`	`16`	`public MedianAbsoluteDeviationAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usage) { }`
`19`	`17`
Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,7 @@`
`8`	`8`
`9`	`9`	`namespace Tests.Aggregations;`
`10`	`10`
`11`		`-#pragma warning disable CS0618 // Type or member is obsolete`
`12`	`11`	`public abstract class ProjectsOnlyAggregationUsageTestBase : AggregationUsageTestBase<ReadOnlyCluster>`
`13`		`-#pragma warning restore CS0618 // Type or member is obsolete`
`14`	`12`	`{`
`15`	`13`	`protected ProjectsOnlyAggregationUsageTestBase(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }`
`16`	`14`