Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated point styles override user defined point styles #2277

Closed
3 tasks done
nickofthyme opened this issue Dec 8, 2023 · 1 comment · Fixed by #2278
Closed
3 tasks done

Isolated point styles override user defined point styles #2277

nickofthyme opened this issue Dec 8, 2023 · 1 comment · Fixed by #2278
Assignees
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression :styling Styling related issue :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

Describe the issue
With the changes from #2004 to expose isolated point styles, this inadvertently overrides provided styles such as point.radius only for the isolated points

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/romantic-tess-gwvxw4?file=/src/App.tsx
  2. Notice the style difference between the isolated points (i.e. null, value, null).

Expected behavior
We should use merge the styles from LineSeries.lineSeriesStyle.point with LineSeries.lineSeriesStyle.isolatedPoint. Same for
AreaSeries we should merge AreaSeries.areaSeriesStyle.point with AreaSeries.areaSeriesStyle.isolatedPoint.

Screenshots

romantic-tess-gwvxw4 - CodeSandbox 2023-12-08 at 12 53 33 PM

Version (please complete the following information):

Kibana Cross Issues
elastic/kibana#172995

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • Every related Kibana issue is listed under Kibana Cross Issues list and the kibana cross issue tag is applied
@nickofthyme nickofthyme added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :styling Styling related issue :xy Bar/Line/Area chart related labels Dec 8, 2023
@nickofthyme nickofthyme self-assigned this Dec 8, 2023
@markov00
Copy link
Member

There is one more issue related to that:
isolated points in Stacked areas are not shown if the consumer legitimately sets the areaPointStyle visibility to false. This with our default theme (EUI) isolated point on these time of charts are interactive but not visible:

Screenshot 2023-12-18 at 15 56 03

At this point, an isolated point should inherit the style of a point except for the visibility that should always be true, except if explicitly disabled in the isolated point style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression :styling Styling related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants