-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Failing Test]: TestAPMConfig – no such index [traces-apm-default] #5890
Comments
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Most likely it's not a flaky test, rather APM server is unhealthy on the ESS deployment, as shown by the log from the tracer below
|
Thanks, I agree. It's failed 3 builds in a row, so it's unlikely to be flaky. I'll try to spin up an ESS deployment on 9.0.0 and check the health of APM server. |
Indeed, APM Server on 9.0.0 in ESS CFT is unhealthy right now: @simitt Is this something the APM Server team is already aware of? |
Hey @ycombinator 👋 This might be related to the beats bump, let me quickly check |
According to the logs in cloud the error is
Downloading the docker image shows the apm-server config and binary owned by |
Something must've changed very recently because, as of a5de320 (created October 30 00:46 UTC), this test was passing. |
BTW, this looks mighty similar to #5615. |
Seems like it's neither file owner nor permissions this time, the output is identical from both ls -la apm*
-rwxr-xr-x 1 elastic-agent elastic-agent 53936280 Oct 30 17:08 apm-server
-rw-r--r-- 1 elastic-agent elastic-agent 542 Oct 30 17:08 apm-server.spec.yml
-rw-r--r-- 1 elastic-agent elastic-agent 39322 Oct 30 17:08 apm-server.yml |
This Checking ESS CFT region, similar to #5890 (comment) (which was pertaining to So clearly some change that got merged on |
@kruskall referring to my previous comment, could the changes in question be elastic/apm-server#14469 (for |
@ycombinator we were suspecting that it could be related to the beats update, your comment from here #5890 (comment) is reaffirming it. With a local tests however I cannot reproduce this regression, let me think of another way to test this. |
@ycombinator I was able to identify the root cause of the error finally. It's 100% related to the beats update we did. After the update this condition resolves to false in ESS now. I will try to check the history to find the changes in libbeat caused this regression. |
Okay the changes from https://github.com/elastic/beats/pull/41277/files#diff-aec28a4e07878561b81c713b3da56350499ea5fbb44eac866430a249d25acffdR162 are not parsing the |
yep, as @1pkg mentioned, that was the initial assumption but that commit is also in 8.16 which is not affected by the issue. We discussed it today and it could be a change in beats that was not backported to 8.16 |
looks like that PR was not backported to 8.16 so that could be the issue 😅 |
cc'ing @leehinman for awareness, as the author of elastic/beats#41277. |
Ugghhh. I see why my test was insufficient. There was still a This is because APM is Loading the config file early. https://github.com/elastic/apm-server/blob/cb9f315835a3f1c2ba262d07bcdc118568d2d245/internal/beatcmd/config.go#L74 putting a |
@leehinman we call Before the recent changes |
Did you try putting |
@leehinman yes I think the ordering for working with flags parsing in APM Server is off right now. I just opened the fix to move |
The APM Server fix was merged, the tests should be passing again. |
Failing test case
TestAPMConfig
Error message
Build
https://buildkite.com/elastic/elastic-agent-extended-testing/builds/4075#0192dd03-00ea-41c0-a56a-a5edb99318eb
https://buildkite.com/elastic/elastic-agent-extended-testing/builds/4077#0192dd14-e4c3-4901-b0d9-f50065d445b5
https://buildkite.com/elastic/elastic-agent-extended-testing/builds/4086#0192dda7-21c4-4d6a-9ce7-2c9a9ac4a3e3
OS
Linux, Windows
Stacktrace and notes
This test is failing on
main
from 053b320 onwards. Note thatmain
is pointing to9.0.0
now. It is not failing on the8.x
branch.The text was updated successfully, but these errors were encountered: