Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between active/passive message consumption when translating otel spans #5373

Open
stuartnelson3 opened this issue May 31, 2021 · 2 comments

Comments

@stuartnelson3
Copy link
Contributor

Currently, incoming otel spans do not have the required metadata to differentiate between whether the message is being consumed actively or passively. The consumption style (active/passive) decides whether we should create a new transaction or a new span, according to our messaging spec.

Because we cannot differentiate between the two, we have decided to always create new transactions when translating incoming otel spans with type=CONSUMER, making the assumption that the majority of message consumption will be passive.

There is a long-standing specification issue discussing adding the information to make this differentiation possible.

Commit adding an explanatory comment above the relevant code:
98d4f85

@axw
Copy link
Member

axw commented May 31, 2021

There's also a pre-OTel issue: census-instrumentation/opencensus-specs#229. We might want to push for recording the "local root ID" in spans, which would enable us to address this issue as well as set transaction.id on spans like we do for spans produced by Elastic APM agents.

@cyrille-leclerc
Copy link
Contributor

Just discovering this limitation, the solution to create a transaction looks very wise to me, I feel it makes this improvement a lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants