Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGO: Reduce CPU profile size used for PGO #14255

Closed
1pkg opened this issue Oct 3, 2024 · 0 comments
Closed

PGO: Reduce CPU profile size used for PGO #14255

1pkg opened this issue Oct 3, 2024 · 0 comments
Assignees
Milestone

Comments

@1pkg
Copy link
Member

1pkg commented Oct 3, 2024

Description

With the introduction of PGO in #13884, the initial produced CPU profile files seem to be too large, see this pull request for example. This is caused by collecting 100% of the samples in apm-perf and excessive tagging during the benchmarking. Such large profile files are not very well suited to be stored under git. Therefore we should optimize apm-perf to only collect a limited profile sample instead and discard all unnecessary tagging to reduce the size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant