Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel data stream routing does not sanitize values #14043

Closed
carsonip opened this issue Jul 29, 2024 · 1 comment · Fixed by elastic/apm-data#369
Closed

OTel data stream routing does not sanitize values #14043

carsonip opened this issue Jul 29, 2024 · 1 comment · Fixed by elastic/apm-data#369
Assignees
Labels

Comments

@carsonip
Copy link
Member

carsonip commented Jul 29, 2024

OTel data stream routing implemented in elastic/apm-data#201 does not sanitize values, i.e. a - in the supplied dataset / namespace will go through the logic and result in non-compliant data stream name. There are more rules to observe, see in https://www.elastic.co/guide/en/ecs/current/ecs-data_stream.html . There is also an implementation of DS fields sanitization in ES, but there are also issues with Elasticsearch's implementation as stated in elastic/elasticsearch#112936

The bugfix can be a breaking change for existing users and should be stated as such in changelog.

Equiv task in es exporter: open-telemetry/opentelemetry-collector-contrib#34285

@carsonip carsonip added the bug label Jul 29, 2024
@carsonip carsonip transferred this issue from elastic/apm-data Sep 11, 2024
@simitt
Copy link
Contributor

simitt commented Sep 11, 2024

The bugfix can be a breaking change for existing users and should be stated as such in changelog.

Let's call it out in the release notes to make users aware, but generally I would see this as a bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants