Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use radix sort when the comparator is just a key mapping #1176

Open
pca006132 opened this issue Mar 4, 2025 · 1 comment · May be fixed by #1179
Open

use radix sort when the comparator is just a key mapping #1176

pca006132 opened this issue Mar 4, 2025 · 1 comment · May be fixed by #1179
Labels
enhancement New feature or request

Comments

@pca006132
Copy link
Collaborator

Radix sort is faster, but we are not using it as much as possible due to some sort operations requiring custom comparators. We can generalize the radix sort implementation to allow a key mapping function.

The merge function is probably something we can look into as well, it seems that the std implementation is not doing much optimization with it.

@pca006132 pca006132 added the enhancement New feature or request label Mar 4, 2025
@pca006132
Copy link
Collaborator Author

And I forgot why the radix sort is not really a parallel radix sort. I should fix thid...

@pca006132 pca006132 linked a pull request Mar 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant