Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to minify html template code. #60

Open
iplanwebsites opened this issue Mar 25, 2022 · 1 comment
Open

Option to minify html template code. #60

iplanwebsites opened this issue Mar 25, 2022 · 1 comment

Comments

@iplanwebsites
Copy link

Whitespace accounts to 50% of the file-size of generated emails. This can quickly add up in queueing systems that notifies thousands of users.
To save CPU cycles, it'd be best to minimize the templates on init, instead of running the minifier on the output, or at render time.

Ideally just after loading it via this.cachedTheme = fs.readFileSync(themePath, 'utf8');.

@eladnava
Copy link
Owner

Hi @iplanwebsites,
Thanks so much for creating this issue and bringing this to my attention!

Would you like to submit a PR with this performance improvement? It would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants