Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inaccessible OpenIDConnectProvider stops processing all OpenIDConnectProviders #579

Open
Deofex opened this issue Feb 26, 2025 · 1 comment · May be fixed by #576
Open

inaccessible OpenIDConnectProvider stops processing all OpenIDConnectProviders #579

Deofex opened this issue Feb 26, 2025 · 1 comment · May be fixed by #576

Comments

@Deofex
Copy link

Deofex commented Feb 26, 2025

When running aws-nuke with a user that lacks the necessary permissions to retrieve details about a specific OpenIDConnectProvider, the tool currently skips all OpenIDConnectProvider resources rather than only the one for which the user lacks permissions. This leads to an incomplete execution of the nuking process.

Expected Behavior:

aws-nuke should log an error when a user lacks permissions to retrieve details about a specific OpenIDConnectProvider, but continue processing the other OpenIDConnectProvider resources, as it would with other resources that have similar permission issues.

Steps to Reproduce:

Run aws-nuke with a user that has insufficient permissions to retrieve information about at least one OpenIDConnectProvider.
Observe that the tool skips all OpenIDConnectProvider resources instead of just the one lacking permissions.
Check the logs for error messages and the halt in processing.

Create a PR to fix this: #576 (wasn't sure if I also had to create an issue)

@ekristen
Copy link
Owner

@Deofex thanks for the issue and the PR! I saw it, I just hadn't had a chance to review it yet. Both are not necessary, but both are welcome.

@ekristen ekristen linked a pull request Feb 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants