Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the urfave/cli dependency from v2 to v3 #538

Open
ari-becker opened this issue Feb 1, 2025 · 3 comments · May be fixed by #539
Open

Upgrade the urfave/cli dependency from v2 to v3 #538

ari-becker opened this issue Feb 1, 2025 · 3 comments · May be fixed by #539

Comments

@ari-becker
Copy link

https://cli.urfave.org/migrate-v2-to-v3/

v3 factors out context.Context, in line with modern Go practice.

@ari-becker ari-becker linked a pull request Feb 1, 2025 that will close this issue
@ekristen
Copy link
Owner

ekristen commented Feb 1, 2025

If like to understand how you are using it as a library.

I appreciate the PR. V3 isn't out yet so I'm hesitant to switch. I have another project of mine staged to switch just waiting on its release.

@ari-becker
Copy link
Author

I'm not using it yet as a library, just considering it. aws-nuke would be part of a larger AWS account management service, something that would be responsible for cleaning accounts, where the value of including aws-nuke as a dependency would be to not need to track all of the different AWS services to clean. I could shell out, but there should be more control with context.Context compared to SIGTERM.

@ekristen
Copy link
Owner

ekristen commented Feb 3, 2025

If you are going to use it at a library you should look at how the nuke command is implemented and re-implement that function minus the CLI part in my opinion.

You can pass context to the CLI right now too with v2 via os.RunWithContext if I recall correctly.

Either way, v3, is high on my radar, but until it hits it's release I will likely hold on updating it here, or I need better test coverage to ensure things still work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants