Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A widget for all options and a widget for custom options #46

Open
galvarez421 opened this issue Aug 1, 2018 · 1 comment
Open

A widget for all options and a widget for custom options #46

galvarez421 opened this issue Aug 1, 2018 · 1 comment

Comments

@galvarez421
Copy link

It seems that currently there are 3 widgets, one for all brand icons, one for all regular icons, and one for all solid icons.

I think it would be useful to allow for a single widget to include all of the icons.

I also think it would be useful to allow for a completely custom set of options in case it makes sense to present only a limited set of options that would make sense for a particular piece of content.

I imagine this change could be made without changing the API for the existing widgets, for example:

CMS.registerWidget(
  "fontawesome-solid",
  FontawesomeWidget.Solid,
  FontawesomeWidget.Preview
);

CMS.registerWidget(
  "fontawesome-all",
  FontawesomeWidget.All,
  FontawesomeWidget.Preview
);

CMS.registerWidget(
  "fontawesome-directions",
  FontawesomeWidget.Custom([
    'far fa-caret-square-left',
    'fas fa-caret-square-left'
  ]),
  FontawesomeWidget.Preview
);
@ekoeryanto
Copy link
Owner

ekoeryanto commented Aug 1, 2018

It seems that currently there are 3 widgets

yes, we open for other widget request, if you need another widget one.

for the all in one icons, I think it better to create separate bundle as those will be big bundle.
haha i was in hurry

about the custom set, I love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants