Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash in url root, separator is stripped #70

Closed
tomvlk opened this issue Apr 29, 2016 · 6 comments
Closed

Hash in url root, separator is stripped #70

tomvlk opened this issue Apr 29, 2016 · 6 comments

Comments

@tomvlk
Copy link

tomvlk commented Apr 29, 2016

When using url's like this:

url: '/#/home'

it get's stripped as:

https://hostname.com#/home
@ekalinin
Copy link
Owner

Hey @tomvlk

I'm using this tool for url joining: https://github.com/jfromaniello/url-join/
Btw, did you try:

url: '/#!/home'

?

See more details in #45

@tomvlk
Copy link
Author

tomvlk commented Apr 29, 2016

Well, this is what I'm trying right now:

sitemap.add({
  url: '/#!/list',
  changefreq: 'daily',
  priority: 0.8
});

and the result of the XML is:

<url>
      <loc>https://hostname.com/#!/list</loc>
      <changefreq>daily</changefreq>
      <priority>0.8</priority>
</url>

And with the current site /#!/ is not working right, where /#/ is.

@KerrGrah
Copy link

I was able to get around this issue by including the entire url starting from https... so that url-join is not invoked at
if (!reProto.test(link.url)) { link.url = urljoin(self.hostname, link.url); }
seems like you left a good way out!

@ECnetHub
Copy link

The same issue on Angular AP.

@crisp2u
Copy link

crisp2u commented Jun 5, 2019

The relevant issue on url-join is jfromaniello/url-join#10

@derduher
Copy link
Collaborator

derduher commented Jul 1, 2019

As we no longer use url-join this appears to have been fixed '/#/home' renders as <loc>https://hostname.com/#/list</loc> ! or no !

@derduher derduher closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants