pio: check error before deferring f.Close

dmitshur · dmitshur · commit caab482bc4ce · 2019-06-19T23:53:43.000-04:00
Calling f.Close should be done only after the file has been opened successfully.
diff --git a/pio/pio.go b/pio/pio.go
@@ -245,10 +245,10 @@ func GetSiteFileBytes() (b []byte) {
 		log.Fatalf("Could not get pass dir: %s", err.Error())
 	}
 	f, err := os.OpenFile(si, os.O_RDWR, 0600)
-	defer f.Close()
 	if err != nil {
 		log.Fatalf("Could not open site file: %s", err.Error())
 	}
+	defer f.Close()
 	b, err = ioutil.ReadAll(f)
 	if err != nil {
 		log.Fatalf("Could not read site file: %s", err.Error())

Original file line number	Diff line number	Diff line change
`@@ -245,10 +245,10 @@ func GetSiteFileBytes() (b []byte) {`
`245`	`245`	`log.Fatalf("Could not get pass dir: %s", err.Error())`
`246`	`246`	`}`
`247`	`247`	`f, err := os.OpenFile(si, os.O_RDWR, 0600)`
`248`		`- defer f.Close()`
`249`	`248`	`if err != nil {`
`250`	`249`	`log.Fatalf("Could not open site file: %s", err.Error())`
`251`	`250`	`}`
	`251`	`+ defer f.Close()`
`252`	`252`	`b, err = ioutil.ReadAll(f)`
`253`	`253`	`if err != nil {`
`254`	`254`	`log.Fatalf("Could not read site file: %s", err.Error())`