Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about accept a property about to the node installiation in system for supporting some arch or custom patch? #1160

Open
qyl27 opened this issue Aug 13, 2024 · 2 comments · May be fixed by #1165
Open

How about accept a property about to the node installiation in system for supporting some arch or custom patch? #1160

qyl27 opened this issue Aug 13, 2024 · 2 comments · May be fixed by #1165

Comments

@qyl27
Copy link

qyl27 commented Aug 13, 2024

Do you want to request a feature or report a bug?
It's a feature.

I am building packages of some software for Arch Linux RISC-V Port.
Node.js did not provide the prebuilt binary for RISC-V, but we have a patched one provided by the system's package manager.
Jenkins used frontend-maven-plugin to build their frontend page, we can't do many patches to the source in order to build it, so I want to make it use the node in the system.
Would you be willing to accept a property point to a node executable file to replace the default downloaded one? Also, users no longer need to use the exec-maven-plugin.
If that sounds good, I'd love to create a PR for it.
@eirslett
Copy link
Owner

Here's a possible thing you can do: put your patched Node binary inside the .m2 folder of your RISC-V device. With the same layout as it would be on x64 Linux or whatever. Frontend-maven-plugin looks inside your .m2 folder before downloading Node from anywhere else - so that should work.
Maybe try and put your patched binary on https://github.com/nodejs/unofficial-builds/ (which already has RISC-V?) and then the frontend-maven-plugin should be able to download it from there?

@qyl27
Copy link
Author

qyl27 commented Aug 14, 2024

Here's a possible thing you can do: put your patched Node binary inside the .m2 folder of your RISC-V device. With the same layout as it would be on x64 Linux or whatever. Frontend-maven-plugin looks inside your .m2 folder before downloading Node from anywhere else - so that should work. Maybe try and put your patched binary on https://github.com/nodejs/unofficial-builds/ (which already has RISC-V?) and then the frontend-maven-plugin should be able to download it from there?

The main problem is that most Linux distributions don't like to make too many patches to keep reproducibility. (They often use some automatic building system that treats putting binaries into cache dir in build time as a patch, also they didn't like to use the binaries that are not provided by the system package manager.)
If we can use a command-line argument or environment variable, they will be happy.

qyl27 added a commit to qyl27/frontend-maven-plugin that referenced this issue Sep 15, 2024
@qyl27
eirslett#1160 Property to select node path.
fb5261f 
Signed-off-by: 秋雨落 <[email protected]>
@qyl27 qyl27 linked a pull request Sep 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1160 Property to select node path. qyl27/frontend-maven-plugin
2 participants
@eirslett @qyl27