Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if upgrading, first delete the full "node" dir #994

Open
jcompagner opened this issue Aug 4, 2021 · 1 comment · May be fixed by #1123
Open

if upgrading, first delete the full "node" dir #994

jcompagner opened this issue Aug 4, 2021 · 1 comment · May be fixed by #1123

Comments

@jcompagner
Copy link

when i did go from Node 16.2 to 1.6.6 it did do the update to that version
(this is with npm just included, not an extra npm install)

but then weird npm-cli errors came up
when i then really just first delete the "node" dir and let the plugin install node again everything was fine

if i look into:

https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java

i also don't really see a full delete first..

NpmInstaller i do see that that it first does delete stuff.
But not when npm is provided by node i think it is this code:

https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-plugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeInstaller.java#L189

are we needing there 1 line of code that deletes first if it is there the full target dir?

@MonsieurBon
Copy link

I can confirm that upgrading from 14.17.0 to 16.13.1 fails when running npm install. Manually removing the node folder solves the problem. The installed npm version (8.1.2) is the same for both node versions.

adangel added a commit to adangel/frontend-maven-plugin that referenced this issue Nov 23, 2023
@adangel adangel linked a pull request Nov 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants