Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore context.Canceled? #65

Open
gust1n opened this issue Mar 24, 2022 · 0 comments
Open

Ignore context.Canceled? #65

gust1n opened this issue Mar 24, 2022 · 0 comments

Comments

@gust1n
Copy link
Member

gust1n commented Mar 24, 2022

Raising it here for discussion, should we really try to restart a service if canceled by the context and returning context.Canceled? I just wrote some services that basically did:

select {
case <-ctx.Done():
  return ctx.Err()
}

which would then have supervisor-go try to restart them, while I think that could be ignored (e.g. if !errors.Is(err, context.Canceled))

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant