Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sggo: TestCommand is not cacheable #236

Open
ericwenn opened this issue Apr 2, 2022 · 1 comment
Open

sggo: TestCommand is not cacheable #236

ericwenn opened this issue Apr 2, 2022 · 1 comment
Labels

Comments

@ericwenn
Copy link
Member

ericwenn commented Apr 2, 2022

sggo.TestCommand prevents test results from being cached by go tooling.
According to go docs the only flags that may be set for caching to apply is

-benchtime, -cpu, -list, -parallel, -run, -short, -timeout, -failfast, and -v

See docs

After some local testing it seems that -race does not impact caching either.

sggo.TestCommand currently sets the following flags as well (which prevents cache):

  • -race
  • -shuffle on
  • -coverprofile
  • -covermode

It would be great if the default testing with go is cached, to improve feedback velocity when building locally.
Perhaps two different targets:

  • sggo.TestCommand (cached)
  • sggo.TestCoverCommand (not-cached)
Copy link

github-actions bot commented Apr 8, 2024

This issue has been open for 365 days with no activity. Marking as stale.

@github-actions github-actions bot added the Stale label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant