99 "go.opentelemetry.io/otel/attribute"
1010 "go.opentelemetry.io/otel/metric/global"
1111 "go.opentelemetry.io/otel/metric/instrument"
12+ "go.opentelemetry.io/otel/metric/instrument/syncint64"
1213 "go.opentelemetry.io/otel/metric/unit"
1314 semconv "go.opentelemetry.io/otel/semconv/v1.7.0"
1415 "google.golang.org/grpc"
@@ -20,6 +21,7 @@ import (
2021// See:
2122// https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics
2223const (
24+ serverRequestDurationMetricName = "rpc.server.duration"
2325 clientRequestDurationMetricName = "rpc.client.duration"
2426
2527 // there is no rpc_count equivalent int OTEL semantic conventions yet.
@@ -30,23 +32,31 @@ const (
3032func NewMetricMiddleware () (MetricMiddleware , error ) {
3133 meter := global .MeterProvider ().Meter ("cloudrunner-go/cloudmonitoring" )
3234
33- serverRequestCount , err := meter .Int64Counter (
35+ serverRequestCount , err := meter .SyncInt64 (). Counter (
3436 serverRequestCountMetricName ,
3537 instrument .WithUnit (unit .Dimensionless ),
3638 instrument .WithDescription ("Count of RPCs received by a gRPC server." ),
3739 )
3840 if err != nil {
3941 return MetricMiddleware {}, fmt .Errorf ("create server request count counter: %w" , err )
4042 }
41- clientRequestCount , err := meter .Int64Counter (
43+ serverRequestDuration , err := meter .SyncInt64 ().Histogram (
44+ serverRequestDurationMetricName ,
45+ instrument .WithUnit (unit .Milliseconds ),
46+ instrument .WithDescription ("Duration of RPCs received by a gRPC server." ),
47+ )
48+ if err != nil {
49+ return MetricMiddleware {}, fmt .Errorf ("create server request duration histogram: %w" , err )
50+ }
51+ clientRequestCount , err := meter .SyncInt64 ().Counter (
4252 clientRequestCountMetricName ,
4353 instrument .WithUnit (unit .Dimensionless ),
4454 instrument .WithDescription ("Count of RPCs sent by a gRPC client." ),
4555 )
4656 if err != nil {
4757 return MetricMiddleware {}, fmt .Errorf ("create client request count counter: %w" , err )
4858 }
49- clientRequestDuration , err := meter .Int64Histogram (
59+ clientRequestDuration , err := meter .SyncInt64 (). Histogram (
5060 clientRequestDurationMetricName ,
5161 instrument .WithUnit (unit .Milliseconds ),
5262 instrument .WithDescription ("Duration of RPCs sent by a gRPC client." ),
@@ -56,15 +66,17 @@ func NewMetricMiddleware() (MetricMiddleware, error) {
5666 }
5767 return MetricMiddleware {
5868 serverRequestCount : serverRequestCount ,
69+ serverRequestDuration : serverRequestDuration ,
5970 clientRequestCount : clientRequestCount ,
6071 clientRequestDuration : clientRequestDuration ,
6172 }, nil
6273}
6374
6475type MetricMiddleware struct {
65- serverRequestCount instrument.Int64Counter
66- clientRequestCount instrument.Int64Counter
67- clientRequestDuration instrument.Int64Histogram
76+ serverRequestCount syncint64.Counter
77+ serverRequestDuration syncint64.Histogram
78+ clientRequestCount syncint64.Counter
79+ clientRequestDuration syncint64.Histogram
6880}
6981
7082// GRPCUnaryServerInterceptor implements grpc.UnaryServerInterceptor and
@@ -76,11 +88,14 @@ func (m *MetricMiddleware) GRPCUnaryServerInterceptor(
7688 info * grpc.UnaryServerInfo ,
7789 handler grpc.UnaryHandler ,
7890) (resp interface {}, err error ) {
91+ startTime := time .Now ()
7992 response , err := handler (ctx , request )
93+ duration := time .Since (startTime )
8094 code := status .Code (err )
8195
8296 attrs := rpcAttrs (info .FullMethod , code )
8397 m .serverRequestCount .Add (ctx , 1 , attrs ... )
98+ m .serverRequestDuration .Record (ctx , duration .Milliseconds (), attrs ... )
8499 return response , err
85100}
86101
0 commit comments