build: migrate to tools

More decoupled and easier to maintain.

Author: odsod

.cloudbuild/review.yaml

@@ -0,0 +1,9 @@
+steps:
+  - name: gcr.io/einride/cloud-builder
+    args: ["/cloud-builder/git-init.sh"]
+    env:
+      - REPO_NAME=$REPO_NAME
+      - COMMIT_SHA=$COMMIT_SHA
+
+  - name: gcr.io/einride/cloud-builder
+    args: ["make"]

.cloudbuild/rules.mk

@@ -0,0 +1,15 @@
+gcp_project := einride
+github_org := einride
+repo_name := $(shell basename -s .git $(shell git config --get remote.origin.url))
+git_root := $(shell git rev-parse --show-toplevel)
+cloudbuild_root := $(shell realpath --relative-to $(git_root) $(dir $(lastword $(MAKEFILE_LIST))))
+
+.PHONY: gcloud-builds-triggers-create
+gcloud-builds-triggers-create:
+	gcloud beta builds triggers create github \
+		--project=$(gcp_project) \
+		--repo-owner=$(github_org) \
+		--repo-name=$(repo_name) \
+		--pull-request-pattern='.*' \
+		--description='$(repo_name)-review' \
+		--build-config='$(cloudbuild_root)/review.yaml'

.gitignore

@@ -1,2 +1,2 @@
 .idea
-.gobincache
+tools/*/*/

.gitmodules

@@ -0,0 +1,21 @@
+run:
+  timeout: 5m
+  skip-dirs:
+    - gen
+
+linters:
+  enable-all: true
+  disable:
+    - dupl # allow duplication
+    - funlen # allow long functions
+    - gomnd # allow some magic numbers
+    - wsl # unwanted amount of whitespace
+    - godox # allow TODOs
+    - interfacer # deprecated by the author for having too many false positives
+    - gocognit # allow higher cognitive complexity
+    - testpackage # unwanted convention
+    - nestif # allow deep nesting
+    - unparam # allow constant parameters
+    - goerr113 # allow "dynamic" errors
+    - exhaustive # TODO: fix and enable
+    - gofumpt # TODO: enable when whitespace diff issue is resolved

.golangci.yml

@@ -1,61 +1,28 @@
 # all: run a complete build
 all: \
 	markdown-lint \
-	mocks \
+	mockgen-generate \
 	go-lint \
 	go-review \
 	go-mod-tidy \
-	git-verify-nodiff \
-	git-verify-submodules
+	git-verify-nodiff
 
-export GO111MODULE := on
-
-# clean: remove all generated build files
-.PHONY: clean
-clean:
-	rm -rf build
-
-.PHONY: build
-build:
-	@git submodule update --init --recursive $@
-
-include build/rules.mk
-build/rules.mk: build
-	@# included in submodule: build
-
-# markdown-lint: lint Markdown files
-.PHONY: markdown-lint
-markdown-lint: $(PRETTIER)
-	$(PRETTIER) --check **/*.md  --parser markdown
+include tools/git-verify-nodiff/rules.mk
+include tools/golangci-lint/rules.mk
+include tools/prettier/rules.mk
+include tools/goreview/rules.mk
 
 # go-mod-tidy: update Go module files
 .PHONY: go-mod-tidy
 go-mod-tidy:
 	go mod tidy -v
 
-# go-lint: lint Go files
-.PHONY: go-lint
-go-lint: $(GOLANGCI_LINT)
-    # dupl: disabled due to similarities in tests
-	# interfacer: deprecated
-	# maligned: removed to not spend time on config aligment
-	# funlen: tests with many testcases become too long, but should not be split.
-	# unused: buggy with GolangCI-Lint 1.18.0
-	# godox: we keep todos in the history
-	# wsl: too strict
-	$(GOLANGCI_LINT) run --enable-all --skip-dirs build --disable dupl,interfacer,maligned,funlen,unused,godox,wsl
-
-# go-review: review Go files
-.PHONY: go-review
-go-review: $(GOREVIEW)
-	$(GOREVIEW) -c 1 ./...
-
-# mocks: generate Go mocks
-.PHONY: mocks
-mocks: pkg/mockclock/clock.go
+# mockgen-generate: generate Go mocks
+.PHONY: mockgen-generate
+mockgen-generate: pkg/mockclock/clock.go
 
-pkg/mockclock/clock.go: pkg/clock/clock.go $(GOBIN)
-	$(GOBIN) -m -run github.com/golang/mock/mockgen \
+pkg/mockclock/clock.go: pkg/clock/clock.go
+	go run github.com/golang/mock/mockgen \
 		-destination $@ \
 		-package mockclock \
 		github.com/einride/clock-go/pkg/clock Clock,Ticker

Makefile

@@ -0,0 +1,3 @@
+# clock-go
+
+Clocks and mocks.

README.md

@@ -1,6 +1,6 @@
 module github.com/einride/clock-go
 
-go 1.12
+go 1.13
 
 require (
 	github.com/golang/mock v1.3.1