Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block request #268

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Add block request #268

merged 2 commits into from
Feb 19, 2025
+495 −59

Conversation

bamzedev
Copy link
Contributor

@bamzedev bamzedev commented Feb 18, 2025 •
edited
Loading

This PR adds network block request. The finalization part is still a mock, basically if there are 5 children we consider it finalized. It's not currently used, but it made sense to include it as the service is being used already in the block request. Leaves are descendants of the latest finalized block with no known children (this is from UP 0: Block announcement).
Closes #200

@bamzedev bamzedev requested a review from a team February 18, 2025 14:43
greywolve
greywolve previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@greywolve greywolve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise seems fine to me. :)

@bamzedev bamzedev merged commit 12424ca into main Feb 19, 2025
3 checks passed
@bamzedev bamzedev deleted the add-block-request branch February 19, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pantrif pantrif pantrif approved these changes

@greywolve greywolve Awaiting requested review from greywolve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CE 128: Block request
3 participants
@bamzedev @greywolve @pantrif