rfc: Add deal parameters #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan46
requested review from
cernicc,
Jinxit,
th7nder,
jmg-duarte and
pete-eiger
jmg-duarte
reviewed
Feb 19, 2025
th7nder
reviewed
Feb 19, 2025
There was a problem hiding this comment.
If we had to go with it as a MVP, I'd approve it. Left some comments to consider, but overall looks good. I don't know, when I was thinking about it the first time it felt more complex, maybe I was overthinking.
I think that the choice that SPs are setting those parameters by themselves is simplifying this work a lot. We'd need to suggest 'some prices for them' as a default for starters, to encourage SP to onboard, but I think from the technical standpoint it'll work.
aidan46
force-pushed
the
rfc/760-deal-parameters
branch
from
e953285 to
30747b1
Compare
cernicc
reviewed
Feb 20, 2025
Jinxit
reviewed
Feb 20, 2025
Jinxit
reviewed
Feb 20, 2025
cernicc
approved these changes
Feb 20, 2025
jmg-duarte
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an RFC for adding deal parameters that the storage provider can set. Allowing use-case like automatic deal making and auction houses.
Closes #760