Postgres db connector #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated depdencies to latest version
rotiv13
force-pushed
the
postgres-db-connector
branch
from
ee560e9
to
61e7209
Compare
|
Looks good, Thanks!
|
|
|
|
@ehsaniara this was an initial draft there is a problem with this implementation. which if for some reason the lock doesn't get deleted it will be locked forever and it needs manual intervention. I would like to implement a clean up which would check if a lock is expired based on the ttl and the now time both when trying to acquire the lock and when starting up the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for some feedback on what the postgres connector can improve as this is a really simple solution for the connection to the database and don't know what pitfalls it might have until I look at it better