Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AqlToDtoParser ignores some part of the query as converting the AQL to Dto #380

Closed
6 tasks
smnrdln opened this issue Aug 5, 2022 · 3 comments
Closed
6 tasks
Labels
bug Something isn't working

Comments

@smnrdln
Copy link

smnrdln commented Aug 5, 2022

Configuration information

  • EHRbase version:
  • openEHR_SDK version: v1.5.0 (Same behaviour with v1.19.0)
  • Archie version:
  • PostgreSQL version:
  • Java Runtime version:
  • Operating System version:

Steps to reproduce

During testing the app num-portal we noticed that the AQL query process doesn't work correctly. As mentioned and discussed here some part of the AQL query will be ignored after parsing and converting to Dto. For example, given the following AQL query:

SELECT
  e1/data[at0001]/items[at0002]/value/defining_code/code_string as code
FROM
  EHR e
  contains COMPOSITION c0[openEHR-EHR-COMPOSITION.report.v1]
  contains EVALUATION e1[openEHR-EHR-EVALUATION.problem_diagnosis.v1]
WHERE
  (c0/archetype_details/template_id/value = 'KDS_Diagnose'
  AND e1/data[at0001]/items[at0002]/value/defining_code/code_string LIKE 'I50*')

gives the following result:

SELECT
  c0 as KDS_Diagnose
FROM
  EHR e
  contains COMPOSITION c0[openEHR-EHR-COMPOSITION.report.v1]
WHERE
  c0/archetype_details/template_id/value = 'KDS_Diagnose'

Actual result

Expected result (Acceptance Criteria)

Definition of Done

  • The defect is checked by an unit or an integration test (Robot)
  • Merge Request approved
  • Unit tests passed
  • Build without errors
  • Release notes prepared
  • No additional runtime warnings
@smnrdln smnrdln added the bug Something isn't working label Aug 5, 2022
@stefanspiska
Copy link
Contributor

stefanspiska commented Aug 11, 2022

@smnrdln

'like ' is currently not supported by the sdk aql dto model.

(@vladislavploaia @vidi42 for info; internal number https://jira.vitagroup.ag/browse/CDR-488)

@Unaimend
Copy link

Unaimend commented Aug 19, 2022

Is there any way to work around this issue?

@stefanspiska
Copy link
Contributor

this was fixed in the new AQL Dto model #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants