Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step width 8.33 kHz treated differently in regular scanning and spectrum analyzer #589

Open
catequalsgood opened this issue Jul 1, 2024 · 3 comments

Comments

@catequalsgood
Copy link

catequalsgood commented Jul 1, 2024

This might be intentional but I noticed that in regular scanning mode a step width of 8.33 kHz always leads to 25 kHz increments after three steps, as expected. But in the spectrum analyzer the step seems to literally be treated as 8.330 kHz. This causes a growing mismatch between scanned frequency and valid air band channel frequencies.
The attached image shows the result of entering the spectrum analyzer with a scanning range of 118.000 to 137.000 MHz showing invalid air band frequencies for both the current and highest frequency.

IMG_1942

@prokrypt
Copy link

prokrypt commented Jul 2, 2024

Definitely not supposed to happen. Someone forgot to FREQUENCY_RoundToStep() in a few places.

I had a go at fixing it @ prokrypt@0b62694

prokrypt referenced this issue in prokrypt/uv-k5-firmware-custom Jul 2, 2024
@catequalsgood
Copy link
Author

The upper limit is now displayed as "136.99999" but I can live with that. Other than that it seems to be working perfectly. Thanks!

@prokrypt
Copy link

prokrypt commented Jul 4, 2024

The upper limit is now displayed as "136.99999" but I can live with that. Other than that it seems to be working perfectly. Thanks!

Indeed. I figured it wasn't worth using extra bytes to fix such a small display quirk. Also, on my fork of the firmware the "last frequency" (137MHz) is not scanned anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants