Optimized Dockerfile #577
Open
Optimized Dockerfile #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new Dockerfile to be used with the
compile-with-docker.shscript.The original Dockerfile copies code into the container and creates compiled firmware owned by root. This one mounts the repo as a volume under
/app. The compilation step is run by the current userid instead of root. The resultant artifacts are correctly chmodded to 644, as they are not executables. The stray copy offirmware.ldthat shows up incompiled-firmwareis now omitted. This Dockerfile brings in fewer dependencies, in my case decreasing the size of the build container from 4.24GB to 3.75GB.The same approach could likely be taken with
compile-with-docker.bat, but I don't have a Windows system here for development.Fixes #576