Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX: Open with #74

Open
irrelevantat opened this issue Aug 29, 2016 · 5 comments
Open

OSX: Open with #74

irrelevantat opened this issue Aug 29, 2016 · 5 comments
Labels
bug contribution welcome

Comments

@irrelevantat
Copy link

When opening a file on OSX with "Open with" the file does not open at all.

OSX: 10.11.6
Eme: 0.8.0

iqtoun7szu
@egoist egoist added the bug label Aug 29, 2016
@irrelevantat
Copy link
Author

@egoist I'd be motivated in improving the open-with logic and make a pull request. Interested?

@egoist
Copy link
Owner

egoist commented Aug 31, 2016 •
edited
Loading

Sure, I'd appreciate it. I've updated the code base to use Vue 2, make sure to pull --rebase before sending PR 😋

// Edit: reverted to vue 1, there're some bugs with vue 2 and vuex 1 😓

@daviewales
Copy link

@sebastian-hojas Have you made any progress on this?

@irrelevantat
Copy link
Author

No, unfortunately I don't have time for this at the moment.

@elite-sheep elite-sheep mentioned this issue Jul 4, 2020
Merged
elite-sheep added a commit that referenced this issue Jul 5, 2020
@elite-sheep
Fix Open-With bug in MacOS
025544a 
- Add File Association.
- Mitigate #74 : We can use Open With in MacOS, but there is still a small edge cases.
- Upgrade Babel.
@elite-sheep
Copy link
Collaborator

@sebastian-hojas I have a fix on this issue. Please refer to my PR above.
There is still a small edge cases. After we close all windows and try to use open-with, we will get no result.
It is because there is a bug in electron 2.x that all 'close' events for windows are ignored.
I will try to fix this after we upgrade EME to electron 7.x+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug contribution welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@irrelevantat @daviewales @egoist @elite-sheep