Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change time when signature is checked #236

Open
ligi opened this issue Mar 5, 2023 · 0 comments
Open

Change time when signature is checked #236

ligi opened this issue Mar 5, 2023 · 0 comments

Comments

@ligi
Copy link
Member

ligi commented Mar 5, 2023

Currently we check the signature when submitting the transaction

https://github.com/esPass/pretix-eth-payment-plugin/blob/inlining-checkout/pretix_eth/views.py#L81

but it should be checked before even crafting the transaction.
This is especially important when allowing WalletConnect / other providers in single receiver mode as then the Wallet could be a smart contract wallet and the normal recover has more failure paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant