Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security/Decentralisation: get exchange rate via makerDAO oracle #2

Closed
ligi opened this issue Jun 4, 2019 · 1 comment
Closed

Security/Decentralisation: get exchange rate via makerDAO oracle #2

ligi opened this issue Jun 4, 2019 · 1 comment
Labels
enhancement New feature or request priority:medium

Comments

@ligi
Copy link
Member

ligi commented Jun 4, 2019

this

rate = requests.get('https://api.bitfinex.com/v1/pubticker/' + request.session['fm_currency'] + 'usd')

could be replaced with a query of the MakerDAO price oracle - perhaps even via INCUBED.

Otherwise it is easy for bitfinex to get cheap tickets as far as I see ,-)
@ligi ligi mentioned this issue Jun 4, 2019
Closed
@ligi ligi added enhancement New feature or request priority:medium labels Jun 4, 2019
jpitts pushed a commit to jpitts/pretix-eth-payment-plugin that referenced this issue Jul 14, 2019
@pedrouid
Merge pull request efdevcon#2 from esPass/master
6a8fbc9 
update
@ligi
Copy link
Member Author

ligi commented Jul 17, 2019

closing in favor of #66 - this one here is outdated anyway as it is now a setting and not a api call

@ligi ligi closed this as completed Jul 17, 2019
@skylarweaver skylarweaver mentioned this issue Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ligi