Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code examples didn't work #22

Open
doverradio opened this issue Aug 23, 2020 · 2 comments
Open

Code examples didn't work #22

doverradio opened this issue Aug 23, 2020 · 2 comments

Comments

@doverradio
Copy link

Hi, I just tried to run the code examples in a newly initialized directory and got this output:

k# node 0test.js
/root/node-scrapy-examples/0test.js:5
scrapy.scrape(url, selector, function(err, data) {
       ^

TypeError: scrapy.scrape is not a function
    at Object.<anonymous> (/root/node-scrapy-examples/0test.js:5:8)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47
@stefanmaric
Copy link
Member

Hi @doverradio

Thanks for reporting the issue.

The main branch (master, at that time) was pointing to the legacy version.

I've changed the main branch, updated some dependencies, updated the README examples to work with the latest Github UI, and published a new version.

Please give the new examples a try and let me know if works now.

@mariusa
Copy link

mariusa commented Dec 12, 2020

README Example works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants