Skip to content

Commit b81162e

Browse files
committed
Merge commit 'e44fe5d1d41c1db66b9d2bc0bb11f8fa60eab0b0'
2 parents f040f7c + e44fe5d commit b81162e

File tree

5 files changed

+27
-12
lines changed

5 files changed

+27
-12
lines changed

Assets/Oculus/OculusProjectConfig.asset

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ MonoBehaviour:
1212
m_Script: {fileID: 11500000, guid: 05d394ae2a81edd4cbc3c51917e766e3, type: 3}
1313
m_Name: OculusProjectConfig
1414
m_EditorClassIdentifier:
15-
targetDeviceTypes: 0100000002000000
15+
targetDeviceTypes: 02000000
1616
allowOptional3DofHeadTracking: 0
1717
handTrackingSupport: 0
1818
handTrackingFrequency: 0

Assets/PlatformConfigMobile.asset

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ MonoBehaviour:
1414
m_EditorClassIdentifier:
1515
HullBrushMaxVertInputs: 400
1616
HullBrushMaxKnots: 900
17-
ReferenceImagesMaxFileSize: 10485760
18-
ReferenceImagesMaxDimension: 4352
19-
ReferenceImagesResizeDimension: 1024
17+
ReferenceImagesMaxFileSize: 20000000
18+
ReferenceImagesMaxDimension: 2785280
19+
ReferenceImagesResizeDimension: 8192
2020
MemoryWarningVertCount: 1000000
2121
UseFileSystemWatcher: 1
2222
EnableAutosave: 0
@@ -29,7 +29,6 @@ MonoBehaviour:
2929
EnableExportGlb: 1
3030
EnableExportJson: 0
3131
EnableExportUsd: 0
32-
EnableExportLatk: 1
3332
EnableExportMemoryOptimization: 1
3433
EnableMulticamPreview: 1
3534
EnabledMulticamStyles: 000000000100000002000000

Assets/Scripts/GUI/LoadBackgroundImageButton.cs

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ public class LoadBackgroundImageButton : BaseButton
2222
{
2323
public ReferenceImage ReferenceImage { get; set; }
2424

25+
[SerializeField] private LocalizedString m_ErrorHelpText;
26+
2527
public void RefreshDescription()
2628
{
2729
if (ReferenceImage != null)
@@ -43,7 +45,7 @@ public void RefreshDescription()
4345
}
4446
override protected void OnButtonPressed()
4547
{
46-
if (ReferenceImage == null)
48+
if (ReferenceImage == null || !ReferenceImage.Valid)
4749
{
4850
return;
4951
}
@@ -54,16 +56,18 @@ override public void ResetState()
5456
{
5557
base.ResetState();
5658

57-
// Make ourselves unavailable if our image has an error.
58-
bool available = false;
59-
if (ReferenceImage != null)
59+
if (ReferenceImage == null)
6060
{
61-
available = ReferenceImage.NotLoaded || ReferenceImage.Valid;
61+
return;
6262
}
6363

64-
if (available != IsAvailable())
64+
if (!ReferenceImage.Valid)
6565
{
66-
SetButtonAvailable(available);
66+
SetDescriptionText(App.ShortenForDescriptionText(ReferenceImage.FileName), ImageErrorExtraDescription());
67+
}
68+
else
69+
{
70+
SetDescriptionText(App.ShortenForDescriptionText(ReferenceImage.FileName));
6771
}
6872

6973
RefreshDescription();
@@ -77,5 +81,11 @@ public void Set360ButtonTexture(Texture2D rTexture, float aspect = -1)
7781
m_ButtonRenderer.material.SetFloat("_Stereoscopic", isStereo);
7882
}
7983

84+
85+
public string ImageErrorExtraDescription()
86+
{
87+
return m_ErrorHelpText.GetLocalizedStringAsync().Result;
88+
}
89+
8090
}
8191
} // namespace TiltBrush

Assets/Scripts/GUI/LoadReferenceImageButton.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,18 @@
1515
using UnityEngine.Localization;
1616
using UnityEngine;
1717

18+
using UnityEngine.Localization;
19+
using UnityEngine;
20+
1821
namespace TiltBrush
1922
{
2023

2124
public class LoadReferenceImageButton : BaseButton
2225
{
2326
public ReferenceImage ReferenceImage { get; set; }
2427

28+
[SerializeField] private LocalizedString m_ErrorHelpText;
29+
2530
public void RefreshDescription()
2631
{
2732
if (ReferenceImage != null)

Assets/Settings/Localization/Strings/Strings_en.asset

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ MonoBehaviour:
1212
m_Script: {fileID: 11500000, guid: e9620f8c34305754d8cc9a7e49e852d9, type: 3}
1313
m_Name: Strings_en
1414
m_EditorClassIdentifier:
15+
m_EditorClassIdentifier:
1516
m_LocaleId:
1617
m_Code: en
1718
m_SharedData: {fileID: 11400000, guid: c84355079ab3f3e4f8f3812258805f86, type: 2}

0 commit comments

Comments
 (0)