Fix your_first_dart_app
branch to work
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @eee-c.
Thank you for your great dart-comics!
Environment
$ dart --version Dart VM version: 1.24.3 (Wed Dec 13 23:26:59 2017) on "macos_x64" $ pub --version Pub 1.24.3
Problem
I tried dart-comics on
your_first_dart_app
branch. However, something didn't work well. So I just fixed it.The following commands are what I did
After typing the commands, I got the following page which is just HTML source.
About this PR
What I did are
name
inpubspec.yaml
becausepub
said "name" field must be a valid Dart identifier.sdks.dart
in pubspec.lock (pub
command did automatically)master
branch)comics.dart.js
bydart2js
commandThen, you have right page like the following.