Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add associated volume to PPMs #38

Open
1 of 2 tasks
csparker247 opened this issue Aug 11, 2023 · 0 comments
Open
1 of 2 tasks

[Feature] Add associated volume to PPMs #38

csparker247 opened this issue Aug 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@csparker247
Copy link
Member

What problem is your feature request solving?

PPMs are often generated from surfaces which have associated volume ID's (i.e. from VC Segmentations as opposed to some random input mesh). However, this information is lost in the PPM encoding. As a consequence, the vc_*_from_ppm utilities generally require the --volume flag in order to function correctly.

What is your feature request?

Add associated volume metadata into the PPM header. The setter and getter will be easy to add to the PerPixelMap class. Changing the PointSetIO interface to support extra metadata fields in the header is more complicated, but not impossible (maybe something with std::optional or std::map or whatever). Updating usages will also require some attention to detail. But generally fairly easy.

What alternative solutions have you considered?

We could make the --volume flag required rather than defaulting to the first one. But that makes single volume .volpkg more annoying to work with and ultimately just makes the user work harder.

Is there anything else we should know that wasn't included already?

No response

Are you proposing to work on this feature yourself?

  • I am willing to submit a pull request for this feature

Code of Conduct

  • I agree to follow this project's Code of Conduct
@csparker247 csparker247 added enhancement New feature or request triage Needs evaluation by developer and removed triage Needs evaluation by developer labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant