Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing first group button #3

Open
dvrhijn opened this issue Jul 7, 2011 · 3 comments
Open

missing first group button #3

dvrhijn opened this issue Jul 7, 2011 · 3 comments

Comments

@dvrhijn
Copy link

dvrhijn commented Jul 7, 2011

Settings:

multiple_slides_visible,
group_numbered_buttons,
number_slides_visible: 1,
transition_type: "fade"

The first group button does not appear until I modify line 119 for the calculation of curr_num, and remove the "+1" at the end.

That might break other set-ups but in my case the button for the first pic appears again correctly, as well as the others!

Agile Carousel v alpha 1
jquery-1.5.1

@edtalmadge
Copy link
Owner

I'll fix this for the next version.

Just curious, why do you use group_numbered_buttons with 1 slide visible?
I was expecting that group_numbered_buttons would be used only with multiple slides visible.

@dvrhijn
Copy link
Author

dvrhijn commented Jul 9, 2011

It functions more like an indicator this way of how large the slideshow
will be, with the added possibility to skip through them in some
unlinear fashion. And on a busy page it's nicer to have only one picture
showing at the time.

On 07/09/2011 04:33 PM, edtalmadge wrote:

I'll fix this for the next version.

Just curious, why do you use group_numbered_buttons with 1 slide visible?
I was expecting that group_numbered_buttons would be used only with multiple slides visible.

@mosalski
Copy link

mosalski commented Nov 4, 2011

For me it was easy to fix:
agile_carousel.alpha.js - line 121
before:
var curr_num = Math.floor((i + 1) / number_slides_visible) * number_slides_visible + 1;
after:
var curr_num = Math.floor((i + 1) / number_slides_visible) * number_slides_visible;

This makes first page to be shown, please leave a comment here in case you have found any disadvantages of this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants