Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issue around some margined block text in vertical layout. #1245

Closed
kitanic opened this issue Oct 30, 2020 · 5 comments
Closed

Rendering issue around some margined block text in vertical layout. #1245

kitanic opened this issue Oct 30, 2020 · 5 comments
Assignees
Labels
CJK vertical writing mode, etc.

Comments

@kitanic
Copy link

kitanic commented Oct 30, 2020

Hi.
I found bad layout result in vertical book.
source: http://umetake.d.dooo.jp/kindle/download/Miserables.epub
Environment: Thorium-1.6.0-alpha.1.323935906

This problem seems to occur when the screen is small or the text is large with paged mode. The central block of text has margin indentation by div. When a line break occurs in the block, it causes an overlap with subsequent text.

The shot below corresponds to the range from id="kobo.97.1" to id="kobo.119.1" of 0006.xhtml in EPUB Package. (8/59 6% on above shot)

OK shot:
ok

Invalid shot: Flowed text overlaps with subsequent paragraph.
invalid

@danielweck danielweck self-assigned this Oct 30, 2020
@danielweck
Copy link
Member

Thank you very much for reporting the issue, and for providing a test/sample EPUB to reproduce the bug. We are in fact already aware of the broken support for RTL (Right To Left) and VWM (Vertical Writing Mode) documents. Related issues:
#139
#959
#327

@danielweck
Copy link
Member

I suspect that the bug you found is an edge case in ReadiumCSS, which applies certain styles that break the text flow under certain border conditions (e.g. viewport size). That being said, it could just be a Chromium bug as well. Let us know if you see a pattern in the CSS debugger / Web Inspector.

CC @JayPanoz

@kitanic
Copy link
Author

kitanic commented Oct 30, 2020

Hmm.
I'm not a web engineer so I don't know if I can provide accurate information.

Anyway, I'm attaching the Web Inspector results when viewed in Safari Chrome. This picture is purely displaying the source HTML in the EPUB package and does not incorporate Readium-CSS.

Additionally, I have try to insert column-width property in < body > manually, this dose not cause any problems.

Does this give you a hint?

Safari:
safari inspector

Chrome:
chrome inspector

@kitanic
Copy link
Author

kitanic commented Nov 4, 2020

I've probably found cause of problem so I'll tell you.

I tried to modify --RS__maxMediaHeight to 1000vw in my test html, this makes correct result. So I think it's because the size of div is limited by max-width in ReadiumCSS-before. I don't know what the right value to put here is for me, but I think the cause is right in this.

@danielweck
Copy link
Member

Merging into duplicate issue #959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CJK vertical writing mode, etc.
Projects
None yet
Development

No branches or pull requests

2 participants