Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDMP-744 - Investigate simplifying potential circularities in the packaging / container specification part of the ontology #607

Open
ElisaKendall opened this issue Jul 3, 2024 · 4 comments
Assignees
Labels
consistency invalid This doesn't seem right

Comments

@ElisaKendall
Copy link
Contributor

There appear to be some significant recursive definitions related to packaging, at least one of which is in the ISO IDMP 11615 specification. Some of the circularity needs to be simplified to address reasoning challenges.

@tw-osthus
Copy link
Contributor

please verify the changes against the Qlaira example. The Amlodipine case is too simple.

@tw-osthus
Copy link
Contributor

We can merge container with container constituency, but we still have to use constainer constituents, because in the Qlaira example we have 2 yellow tablets, 8 red tablets, 4 brown tablets,.. in the same blister. We need the amount of content qualified by type. In Amlodipine it is just one.

@ElisaKendall
Copy link
Contributor Author

please verify the changes against the Qlaira example. The Amlodipine case is too simple.

Agreed. The process will still be incremental - not planning to unwind this all at once.

@mereolog mereolog added this to the Release 1.3.0 milestone Aug 9, 2024
@mereolog mereolog removed this from the Release 1.3.0 milestone Sep 26, 2024
@ElisaKendall
Copy link
Contributor Author

After discussion with BI, it appears that container constituency is actually redundant. Package item has constituent something and something is a constituent of a package item should be retained, with elimination of the need for is defined in related to the constituency. This change will simplify the BI implementation, and likely others, significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants